chore: minor simulator utils cleanup#13250
Merged
Conversation
Contributor
Author
benesjan
commented
Apr 2, 2025
| public async runUnconstrained( | ||
| request: FunctionCall, | ||
| contractAddress: AztecAddress, | ||
| selector: FunctionSelector, |
Contributor
Author
There was a problem hiding this comment.
These 2 params here made no sense as they were also in the FunctionCall.
This was referenced Apr 2, 2025
Closed
1a7a6c2 to
cfdf034
Compare
cfdf034 to
afac202
Compare
afac202 to
7f68fa4
Compare
de330ef to
d7fe962
Compare
Thunkar
approved these changes
Apr 3, 2025
sklppy88
approved these changes
Apr 3, 2025
7f68fa4 to
52b19ed
Compare
d7fe962 to
3dd75a6
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 3, 2025
`executeUnconstrainedFunction` was now unnecessary so I nuked it. Also cleaned up the related function params which were unnecessarily cluttered.
52b19ed to
16c7fae
Compare
nventuro
approved these changes
Apr 3, 2025
8cdc38c to
bf04498
Compare
16c7fae to
1bb16ca
Compare
60dfbf8 to
a1aef8e
Compare
bf04498 to
876c7e0
Compare
a1aef8e to
59a5129
Compare
876c7e0 to
4b2c2f6
Compare
Contributor
Author
Merge activity
|
59a5129 to
0fe5912
Compare
4b2c2f6 to
69df86f
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 4, 2025
🤖 I have created a new Aztec Packages release --- ## [0.84.0](v0.83.1...v0.84.0) (2025-04-04) ### ⚠ BREAKING CHANGES * `UnsconstrainedContext` --> `UtilityContext` ([#13246](#13246)) * `#[utility]` function ([#13243](#13243)) * Validate public setup fns and gas in p2p ([#13154](#13154)) ### Features * `#[utility]` function ([#13243](#13243)) ([945ffa2](945ffa2)) * **avm:** tx hint init ([#13218](#13218)) ([60a1a92](60a1a92)) * Remove 4 byte metadata from bb-produced proof ([#13231](#13231)) ([0dcc915](0dcc915)) * To enable better ci dashboard. ([#13272](#13272)) ([61c6375](61c6375)) ### Bug Fixes * **avm:** fix lookup builder and FF hashing ([#13263](#13263)) ([2633856](2633856)) * ci3-external concurrency bug, reduce grind set ([2c5e830](2c5e830)), closes [#13285](#13285) * ci3-external.yml ([#13291](#13291)) ([6ad68ed](6ad68ed)) * Validate public setup fns and gas in p2p ([#13154](#13154)) ([1ef4add](1ef4add)), closes [#10958](#10958) ### Miscellaneous * `UnsconstrainedContext` --> `UtilityContext` ([#13246](#13246)) ([69df86f](69df86f)) * add some PrivateSet tests ([#13270](#13270)) ([bd9e690](bd9e690)) * bump full prover test to 32 cores. hoping to boost speed. ([#13293](#13293)) ([c8e95dd](c8e95dd)) * deflake p2p reqresp test ([#13271](#13271)) ([b9164fa](b9164fa)) * don't dump on fail. click the link instead. ([#13292](#13292)) ([ba0fb4d](ba0fb4d)) * flake ([#13277](#13277)) ([62c32eb](62c32eb)) * make rahul happy with migration notes ([#13255](#13255)) ([3dd75a6](3dd75a6)) * minor simulator utils cleanup ([#13250](#13250)) ([8a622c9](8a622c9)) * move a couple of `SharedMutableValues` functions outside of impl ([#13283](#13283)) ([df9a40c](df9a40c)) * nuking debug-only logger and various unused functionality in `foundation` ([#13187](#13187)) ([2d38e60](2d38e60)) * prevent eth devnet config contention in ci ([#13260](#13260)) ([1581836](1581836)) * renaming unconstrained function as utility in TS ([#13249](#13249)) ([34d03bb](34d03bb)) * replace relative paths to noir-protocol-circuits ([b5b99f8](b5b99f8)) * Speed up note hashes test ([#13282](#13282)) ([ad23358](ad23358)) * update gov and proposer configs ([#13281](#13281)) ([e1a5be3](e1a5be3)) * update slashing test port ([#13274](#13274)) ([9a1ddc5](9a1ddc5)) * Want to fail fast on test runs and the wider ci run. ([#13258](#13258)) ([f0553b8](f0553b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

executeUnconstrainedFunctionwas now unnecessary so I nuked it. Also cleaned up the related function params which were unnecessarily cluttered.